I can't find anything wrong with my script, can you?

[Laenoar]

So basically, this script isn't working. Anyone knows what's wrong with it?

local NPC_ID = 85010
local QUEST_ID = 90006


function Quest_OnQuestAccept(event, pPlayer, pQuestGiver, questId)
if(pQuestGiver == NPC_ID) and (questId == QUEST_ID) then
pQuestGiver:SendChatMessage(42, 0, "Get ready!")
pQuestGiver:RegisterEvent("Kodos_Spawn", 10000, 1)
end
end

function Kodos_Spawn(QuestGiver, Event)
pGuestGiver:SendChatMessage(12, 0, "Watch out!")
pQuestGiver:RegisterEvent("Kodos_Summon", 15000, 10)
end

RegisterServerHook(14, "Quest_OnQuestAccept")

----------Spells------------


function Kodos_Summon(QuestGiver, Event)
QuestGiver:SpawnCreature (85011, -8246, -2606, 133, 4, 380000)
end

---------End phases----------

[stoneharry]

pQuestGiver is a object not a integer.

Use: pQuestGiver:GetEntry() to return the ID.

[Laenoar]

Alrighty, now my script looks like this:

local NPC_ID = 85010
local QUEST_ID = 90006


function Quest_OnQuestAccept(event, pPlayer, pQuestGiver, questId)
if(pQuestGiver:GetEntry() == NPC_ID) and (questId == QUEST_ID) then
pQuestGiver:SendChatMessage(42, 0, "Get ready!")
pQuestGiver:RegisterEvent("Kodos_Spawn", 10000, 1)
end
end

function Kodos_Spawn(QuestGiver, Event)
pGuestGiver:SendChatMessage(12, 0, "Watch out!")
pQuestGiver:RegisterEvent("Kodos_Summon", 15000, 10)
end

RegisterServerHook(14, "Quest_OnQuestAccept")

----------Spells------------


function Kodos_Summon(QuestGiver, Event)
QuestGiver:SpawnCreature (85011, -8246, -2606, 133, 4, 380000)
end

---------End phases----------

So I saved it, did reloadscripts and I when I accept the quest I get the error 'scripts/TestQuest.lua:6: attempt to index local 'pQuestGiver' <a number value>'.

What's wrong now ;o?

[stoneharry]

Don't use reload scripts. Fully restart the server.

[Laenoar]

Don't use reload scripts. Fully restart the server.

Did that, same error given :/

[stoneharry]

Did that, same error given :/

I see now. The argument was returning a number value (integer) rather than a unit pointer.

function Quest_OnQuestAccept(event, pPlayer, pQuestGiver, questId)

Needs to be changed to:

function OnQuestAccept(event, pPlayer, questId, pQuestGiver)

Where-ever you got the argument order from is incorrect.

[Laenoar]

Alright, thanks for that. Now the first part is working, I get the text 'Get ready!' showing up on my screen.
I first tried summoning with this code, wich I got from somewhere:

function Kodos_Summon(QuestGiver, Event)
QuestGiver:SpawnCreature (85011, -8246, -2606, 133, 4, 380000)
end

But it doesn't seem to work, nor does the NPC say 'Watch out!' wich is supposed to happen 10 seconds after the 'Get ready!'.
Then I decided to try this code for summoning:

function Kodos_Summon(QuestGiver, Event)
QuestGiver:SpawnCreature (85011, -8246, -2606, 133, 0)
end

Still not working, no error given or anything. Any idea what I did wrong now?

[stoneharry]

SpawnCreature(id, x, y, z, o, faction, time) -- set time to 0 to spawn forever till next restart/it dies

Those are the required arguments (more can be supplied - ...time, weapon mainhand, weapon offhand, weapon ranged, phase, save). You do not supply enough arguments for it to spawn successfully.

[Laenoar]

SpawnCreature(id, x, y, z, o, faction, time) -- set time to 0 to spawn forever till next restart/it dies

Those are the required arguments (more can be supplied - ...time, weapon mainhand, weapon offhand, weapon ranged, phase, save). You do not supply enough arguments for it to spawn successfully.

Okay, thank you, so now my scripts looks like this:

local NPC_ID = 85010
local QUEST_ID = 90006


function Quest_OnQuestAccept(event, pPlayer, questId, pQuestGiver)
if(pQuestGiver:GetEntry() == NPC_ID) and (questId == QUEST_ID) then
pQuestGiver:SendChatMessage(42, 0, "Get ready!")
pQuestGiver:RegisterEvent("Kodos_Spawn", 10000, 1)
end
end

function Kodos_Spawn(QuestGiver, Event)
pGuestGiver:SendChatMessage(12, 0, "Watch out!")
pQuestGiver:RegisterEvent("Kodos_Summon", 15000, 5)
end

RegisterServerHook(14, "Quest_OnQuestAccept")

----------Spells------------


function Kodos_Summon(QuestGiver, Event)
QuestGiver:SpawnCreature(85011, -8246, -2606, 133, 0, 14, 0)
end

---------End phases----------

And it says 'Get ready!' but it doesn't seem to properly register the 'function Kodos_Spawn'. Meaning I do not get the NPC to say 'Watch out!' or get any Kodos to spawn. Man, I really appreciate your help. I could probably figure this out if I got a proper error showing up, but nope, no error or anything. Did I do anything wrong registering the event?

[stoneharry]

Okay, thank you, so now my scripts looks like this:


And it says 'Get ready!' but it doesn't seem to properly register the 'function Kodos_Spawn'. Meaning I do not get the NPC to say 'Watch out!' or get any Kodos to spawn. Man, I really appreciate your help. I could probably figure this out if I got a proper error showing up, but nope, no error or anything. Did I do anything wrong registering the event?

I think there is a issue with your Lua engine because I can see pretty obvious errors that should be printing out to console.

At this function:

function Kodos_Spawn(QuestGiver, Event)

You say that the unit pointer passed in is going to be called 'QuestGiver'. But then on the next line, you try to use:

pGuestGiver

Which does not exist in this context.

You can use print("string") to print to console, and thus find where execution stops and why. You can print variables using this method too.

Here is a fixed version of your script:

local NPC_ID = 85010
local QUEST_ID = 90006

function Quest_OnQuestAccept(event, pPlayer, questId, pQuestGiver)
	if(pQuestGiver:GetEntry() == NPC_ID) and (questId == QUEST_ID) then
		pQuestGiver:SendChatMessage(42, 0, "Get ready!")
		pQuestGiver:RegisterEvent("Kodos_Spawn", 10000, 1)
	end
end

function Kodos_Spawn(pQuestGiver, Event)
	pGuestGiver:SendChatMessage(12, 0, "Watch out!")
	pQuestGiver:RegisterEvent("Kodos_Summon", 15000, 5)
end

RegisterServerHook(14, "Quest_OnQuestAccept")

----------Spells------------


function Kodos_Summon(pQuestGiver, Event)
	pQuestGiver:SpawnCreature(85011, -8246, -2606, 133, 0, 14, 0)
end

---------End phases----------

[Laenoar]

Still not working, same thing as I said before. I only get the message 'Get ready!' showing up on my screen :/

[XxXGenesisXxX]

I don't know shit about lua anymore, learnt a little bit of it few years ago, but haven't really touched it since so I may be totally off and wrong. However I did notice, are you meant to have both "end"s there? Cause what's the second one ending? Your first is ending your function yeah? What's the second ending? Or do you have to end the "if" statements?

function Quest_OnQuestAccept(event, pPlayer, questId, pQuestGiver)
	if(pQuestGiver:GetEntry() == NPC_ID) and (questId == QUEST_ID) then
		pQuestGiver:SendChatMessage(42, 0, "Get ready!")
		pQuestGiver:RegisterEvent("Kodos_Spawn", 10000, 1)
	end
end

[stoneharry]

I don't know shit about lua anymore, learnt a little bit of it few years ago, but haven't really touched it since so I may be totally off and wrong. However I did notice, are you meant to have both "end"s there? Cause what's the second one ending? Your first is ending your function yeah? What's the second ending? Or do you have to end the "if" statements?

function Quest_OnQuestAccept(event, pPlayer, questId, pQuestGiver)
	if(pQuestGiver:GetEntry() == NPC_ID) and (questId == QUEST_ID) then
		pQuestGiver:SendChatMessage(42, 0, "Get ready!")
		pQuestGiver:RegisterEvent("Kodos_Spawn", 10000, 1)
	end
end

You end if's.

@OP, test this:

local NPC_ID = 85010
local QUEST_ID = 90006

function Quest_OnQuestAccept(event, pPlayer, questId, pQuestGiver)
	if(pQuestGiver:GetEntry() == NPC_ID) and (questId == QUEST_ID) then
		pQuestGiver:SendChatMessage(42, 0, "Get ready!")
		print("Registering Event")
		pQuestGiver:RegisterEvent("zKodos_Spawn", 10000, 1)
	end
end

function zKodos_Spawn(pQuestGiver, Event)
	print("function called")
	pQuestGiver:SendChatMessage(12, 0, "Watch out!")
	pQuestGiver:RegisterEvent("zKodos_Summon", 15000, 5)
end

RegisterServerHook(14, "Quest_OnQuestAccept")

----------Spells------------


function zKodos_Summon(pQuestGiver, Event)
	print("Spawning creature!")
	pQuestGiver:SpawnCreature(85011, -8246, -2606, 133, 0, 14, 0)
end

---------End phases----------

[Laenoar]

Thanks for all your help, but it's still not working :/, I only get 'Registering Event' printed. I think I should give up, really, I have no idea what's causing this problem.

[stoneharry]

Perhaps events cannot be fired from this hook (similar issues appear in gossip scripts).

Try this as a hack fix:

local NPC_ID = 85010
local QUEST_ID = 90006
local start = false

function Quest_OnQuestAccept(event, pPlayer, questId, pQuestGiver)
	if(pQuestGiver:GetEntry() == NPC_ID) and (questId == QUEST_ID) then
		pQuestGiver:SendChatMessage(42, 0, "Get ready!")
		start = true
	end
end

function QuestGiverSpawns(pUnit, Event)
	pUnit:RegisterEvent("CHeckForEventStarT", 1000, 0)
end

function CHeckForEventStarT(pUnit)
	if start then
		start = false
		pUnit:RemoveEvents()
		pUnit:RegisterEvent("zKodos_Spawn", 4000, 1)
	end
end

RegisterUnitEvent(NPC_ID, 18, "QuestGiverSpawns")

function zKodos_Spawn(pUnit)
	print("function called")
	pUnit:SendChatMessage(12, 0, "Watch out!")
	pUnit:RegisterEvent("zKodos_Summon", 15000, 5)
	pUnit:RegisterEvent("QuestGiverSpawns", 80000, 1)
end

RegisterServerHook(14, "Quest_OnQuestAccept")

----------Spells------------


function zKodos_Summon(pUnit)
	print("Spawning creature!")
	pUnit:SpawnCreature(85011, -8246, -2606, 133, 0, 14, 0)
end

---------End phases----------