Getting attributes in process

[bad6oy30]

I've been working on getting attributes from actors for a while now, and I can't seem to get it down. Right now, I'm getting access violations when I call GetInt(). Can anyone share some insight?

For 1.0.3.10485 I have this setup:

int __cdecl GetPlayerGUID() //0x97EBF0 
void* __cdecl GetActorPtrFromGUID(int) //0x829F90
int __thiscall GetInt(void*, int) //0x8C7700

#define Hitpoints_Cur 103

And I'm running in EndScene:

int myGuid = GetPlayerGUID();
void* myPtr = GetActorPtrFromGUID(myGuid);

// Everything OK up to this point
// Fails here (access violation)
int hp = GetInt(myPtr, Hitpoints_Cur);

// Also fails (access violation):
int hp = GetInt(myPtr, Hitpoints_Cur | 0xfffff000);

The access violation is in GetAttributeFromFAG (0x870f60)

00870F60  push        ebp  
00870F61  mov         ebp,esp  
00870F63  mov         eax,dword ptr [ebp+10h]  
00870F66  mov         ecx,eax  
00870F68  sar         ecx,10h  
00870F6B  xor         ecx,eax  
00870F6D  push        esi  
00870F6E  mov         esi,dword ptr [ebp+0Ch]  ; here
00870F71  and         ecx,dword ptr [esi+0C8h]

[_Mike]

IIrc GetInt wants a pointer to an ACD, not an Actor. I might be wrong though because it's been a while since I used it and I don't have my IDA database on this computer.

[RamirezX]

Calling convention of GetInt is __thiscall .. did you set everything right?
Did you set correct ECX ?

[Valtharak]

as Mike said you need the acd not the RActor

GetACDPtrFromGUID 8170B0

int myGuid = GetPlayerGUID();
void* myPtr = GetActorPtrFromGUID(myGuid);
int acdguid = read(myPtr +4)
void* myPtrAcd = GetACDPtrFromGUID(acdguid);

int hp = GetInt(myPtrAcd, Hitpoints_Cur | 0xfffff000);

[bad6oy30]

Thanks a lot Mike & Valtharak... that's definitely got me back on track. I'm now reading a value that changes as my HP changes in-game.

That value I'm getting however is confusing me... here's how my hit-points correlate to the value read from GetInt:

31,676 (0x7BBC) reads 0x46f77814 (1,190,623,252)
30,519 (0x7737) reads 0x46ee6de1 (1,190,030,817)
25,492 (0x6394) reads 0x46c72714 (1,187,456,788)
130 (0x82) reads 0x43020000
140 (0x8c) reads 0x430c0000

Reading another attribute (Vitality_Total) with GetInt is also giving wacky results:
9 -> 0x41100000
10 -> 0x41200000

void WriteText(std::wostream& os)
{
	int guid = GetPlayerGUID();
	void* pActor = GetActorPtrFromGUID(guid);
	os << "Player GUID: " << std::hex << guid << ", pActor: " << pActor;
	if (0 != pActor)
	{
		int acdGuid = *(int*)((char*)pActor + 4);
		void* pACD = GetACDPtrFromGUID(acdGuid);
		os << ", acdGuid: " << acdGuid << ", pACD: " << pACD;
		if (0 != pACD)
		{
			os << ", attr: " << GetInt(pACD, _testAttrib | 0xfffff000);
		}
	}
	os << '\n';
}

[bad6oy30]

Sorry... it looks like those are floats... disregard query, and thanks again.