[Release] PVPForAll [C++]

[Trle94]

This is little script that allows every one PVP everywhere

#include "StdAfx.h"
#include "Setup.h" 

void FirstLogin(Player* plr)
{
    plr->SetFlag(PLAYER_FLAGS, PLAYER_FLAG_FREE_FOR_ALL_PVP);
};


    
void SetupLogin(ScriptMgr * mgr)
{
    mgr->register_hook(SERVER_HOOK_EVENT_ON_FIRST_ENTER_WORLD, (void*)FirstLogin);
}

Credits
- LunarSCR Team

[Nightblizzard]

This will set Free for all Flags for PvP only you should use PLAYER_FLAG_PVP.

[Maikash2]

Because it only sets when you login, wouldn't it turn off if you entered an arena and then left?

[FaTaL-V1CT1M]

Could you explain what this actually does please ?

[Maikash2]

Really? There's like less than 10 lines of code, can you take a guess?
--This thought process is supposed to be if I had no clue about coding--

void FirstLogin(Player* plr)

Is the first bit that looks important right? It's called "FirstLogin" so I'm guessing that that's gonna be called when you first login... Then you have

plr->SetFlag(PLAYER_FLAGS, PLAYER_FLAG_FREE_FOR_ALL_PVP)

that looks intimidating right? Well... look at it from different angles... "plr" obviously means player and the "->" could mean that whatever is coming up is executed onto player... right? And then we have "SetFlag" so it's gonna change a flag on the player to something else.. then "PLAYER_FLAGS" not really sure right away, but it could just be all the player's flags right? And then "PLAYER_FLAG_FREE_FOR_ALL_PVP". So this is gonna set it like your in an arena and it's ffa even against your own alliance..

That wasn't too hard was it?

[FaTaL-V1CT1M]

... Like i didnt expect that... I did just want some info about how the script is... Meaning if it stays that way cause Firstlogin sounds like if you relog once it will be over.... Thats what i ment... Tho :P atleast you explained something if some1 actually has 0 idea bout what this is.

FaTaL-V1CT1M =D

[TheSpidey]

SERVER_HOOK_EVENT_ON_FIRST_ENTER_WORLD is only called once per char. Use ON_ENTER_WORLD instead.
Additionally, you should disable the part in your core that unsets the FFA flag once a player exists a FFA area. Otherwise, players would just enter any FFA zone and then leave it to get rid of their FFA flags

[Jotox]

Yeahhh this is a bit of a fail.

Look at what Spidey said.

Btw as Spidey said, an ON_ENTER_WORLD hook would work, but if you don't want a major core edit you should just make an ON_ZONE hook that sets the flag every time you zone (thus if the core unsets your flag because you enter a sanctuary or something, the script will re-set it.)