I have had this problem time and time again so i figure i would post here since i dont see any threads about this issue. there is plenty of threads that explain how to make it public but what they do not tell you is. You have to have your ports open in order to make it public. will give link at end.
Logon - ( should look like this )
<Listen Host = "0.0.0.0" <---0.0.0.0 means listen to all hosts(ips)
ISHost = "0.0.0.0" <---0.0.0.0 means listen to all hosts(ips)
RealmListPort = "3724" <-- (3724) port that needs to be open
ServerPort = "8093"> <--also
<Client MinBuild = "9551"
MaxBuild = "9999"><--- makes server available to 3.0.x users
<LogonServer RemotePassword = "ascent" (ascent) mysqlpsw i
AllowedIPs = "127.0.0.1/32" <--Local Host
AllowedModIPs = "127.0.0.1/32"> <--Local Host
Realms -
<LogonServer Address = "127.0.0.1" <-- the ip the logon server is located on (which is local host ip)
Port = "8093"
<Realm1 Name = "Funserver"
Address = "127.0.0.1:8129" <--change 127.0.0.1 to your DNS or IP
Icon = "PVP"
Population = "1.0"
TimeZone = "1">
World -
<Listen Host = "0.0.0.0"
WorldServerPort = "8129">
then after you saved all that Start Mysql>apache>Logon>world
If you get a error in Mysql saying its already running press alt+ctrl+del and close all sql processes you can find and try again.
As i said before This does not ALWAYS work for everyone. Ports will need to be opened to make people be able to connect to your server. your port is most likely closed and not allowing traffic to your wow server if you did everything correctly on the world logon and realm files. when you go to the web page it will show you a list of routers and modems(dsl/cable) then from when you click on the correct one you have it will guide you through on how to open your ports. The ports that you will need to open are all listed in the config files just right them all down and then open the ports one by one. Make sure you right a list of which onse you already have opened.
There you go =) hopefully i was of some help to some people. if anyone finds this confusing please list where so i can edit it for others please.
PortForward.com - Free Help Setting up Your Router or Firewall