[Release] OnPvPKill Level up

[mager1794]

this is a script for PvP servers mostly it levels up on PvP kill if you level is = to or higher than your targets

#include "Setup.h"
#include "StdAfx.h"

void PvPLevelUp(Player * Plr, Player * Victim)
{
	if(Plr->getLevel() >= Victim->getLevel() && Plr->IsPlayer()== true && Victim->IsPlayer()== true)
	{
		int level;
		level = Plr->GetUInt32Value(UNIT_FIELD_LEVEL);
		level = level++;
		Plr->SetUInt32Value(UNIT_FIELD_LEVEL,level);
	}
	else
	{
	}
};

void SetupPvPKill(ScriptMgr * mgr)
{
	mgr->register_hook(SERVER_HOOK_EVENT_ON_KILL_PLAYER, (void*)PvPLevelUp);
}

its untested so tell me how it works please

[BrantX]

FIRST!
Ha haha, Posting on a epix thread.
Another good release from Mager. Zomg can't rep /cry, +Love to you for the C++ Script .

[**Sweeny**]

2ND WOOT!
Mager how did you get so epic this sounds so awesome...
EDIT* Oh an rep added

[marcojoao]

3º. *_* nice one dude!!
Love you!!
+ rep!!

[Cursed]

Not bad for PvP Servers... +Rep added... (Sorry, can't tell you I luf you )

[Dythzer]

Just some tips for better/more clean code... In bool functions you don't need to do "IsPlayer() == true", "IsPlayer()" is enough (and !IsPlayer() for false). And the else statement doesn't need to be added after the if statement if you're not gonna put anything there.
Also, instead of having:

int level;
level = Plr->GetUInt32Value(UNIT_FIELD_LEVEL);
level = level++;

you could simply do:

int level = Plr->getLevel() + 1;

Also there should be a function for giving level that you can use instead of typing "Plr->SetUInt32Value(UNIT_FIELD_LEVEL,level)" Don't know about that function since i've never used ascent but it's probably something like LevelUp() or GiveLevel(). Otherwise code looks fine.