[c++] problem with reading memory

[Lucani]

Hello!

I want know why my program don't get right values.

Here is my code:

void __fastcall TForm1::Button1Click(TObject *Sender)
{
	HWND hWnd;
	DWORD processId;
	HANDLE hProcess;
	hWnd = FindWindow(0, "World of Warcraft");
	if (hWnd)
    {
        GetWindowThreadProcessId(hWnd, &processId);
	    hProcess = OpenProcess(PROCESS_ALL_ACCESS, false, 0x680);
	    char name[30];
	    ReadProcessMemory(hProcess, (LPVOID)(0x763BB8), &name, 30, 0);

        Form1->ECharName->Text=name;
    }
    else
    {
        Form1->ECharName->Text="WoW not runned";
    }
}

I see right value in Cheat Engine, but when i try get it in my program I get something like that "Dß_", I also tried use many processId whitch i found in Cheat engine process and window list but it doesnt work,

Could someone help me in this small problem ?

[macintox]

are you sure what you are looking for is stored in 30 sizeof(char) ? if your trying to seek a float or int make a temp float or int var, and size 4 for exemple

[Lucani]

I'm sure thats right address and type, of course in my source was little mistake, it should be:

hProcess = OpenProcess(PROCESS_ALL_ACCESS, false, processId);

But it still doesn't work, I downloaded Delphi source, reading memory is very similar - I use same address and type and in Delphi I got right values, but in this downloaded source there are many lines which I don't understand

in my code , to get wow process id, i only use this:

hWnd = FindWindow(0, "World of Warcraft");
GetWindowThreadProcessId(hWnd, &processId);

the problem is also with reading another things from wow memory,

could someone gimme mini example code how to do it in right way?

[Xarg0]

Hi, your ReadProccessMemory call is wrong, a char array with 30 members isn't 30 bytes long, it's 4*30 bytes long, since a char is like a int a 4byte sized variable type (chars are integer), I'd recommend you to youse the sizeof() function instead of a fixed byte value:
MemoryReadProcess(hProcess, (LPVOID) Adress, &name, sizeof(name[30]),0);
that should do the trick.

Edit: wupps forgott that your name var is a cahr array, sizeof(name) would've returned 4 bytes ^^, since the name of char array is it's entry point adress :-)