APB Infinite

[alklas]

hello there,
which decompiler do you use ? i tried decompling this EXE but i get mainly assembly language code (which i understand but this is really uggly)

[pkarlos]

To lazy ehh? Gave link. Not going to bother with explaining how I added the multi-character and how to use it if you can't even bother to click a link and just speed read/or just scroll down.

I do appreciate your attempt to be helpful, however I am not having any luck searching the thread or your posts in this forum and have not found a post of yours with the link yet , and I have checked the website of the script for a post of yours with info! I have since reviewed your posts a third time, however did notice I was missing the link because the font and color were not indicative of a link the one post you have. Also when I previous clicked your name and viewed your posts in that list it did not link to anything until I actually clicked the post and entered it. So please instead of being rude be a little less critical and more understanding that not everyone is you and has the same computer setup as you.

[pkarlos]

Since this bot is obviously abandoned, I'm looking for permission to continue work on it/derive from it. I have currently decompiled it because it was leaking memory like there was no tomorrow and I had to fix it so that I could continue using it. Still hunting the last memory leak but I've fixed the biggest one already. So if the author is still reading this thread, let me know otherwise I'll just keep any changes fixes to it to myself. If the author is not still reading this and someone got his mail, please PM me with it so that I may contact him.

I have politely made several attempts to contact the developer and even private messaged him on this forum over the past couple months, and he has not responded even by email even though it shows he has logged onto this site many times. I don't think you really need permission, even though it is nice and proper educate to get permission. The archive of this program does not contain any licence or copyright, but I would still credit cyrealkiller and the previous bot maintainer. if they object in the future then I am sure you can pull it.

[Llewellyn]

Hi,

I think I've nailed every major leak right now. Will leave it overnight profiling to make sure. Currently private bytes are fluctuating around 130mb which is normal. Let's see if it's still there in the morning. If it's fine I'll upload. Maybe in new thread?

I would really like to see your version for testing. CK did a great job reworking the original, but I feel too, that his project has no new version coming.

[BaseN]

Mind describing the changes you've made? I've got Ants for profiling but only fixed one memory leak after an out of memory error not much more. I'd be happy to share my approach / code with collecting all slots first before starting tasks, adding timeouts to ALL of the while/do-while loops, and auto-start+crash recovery.

Basically I'm doing the same on this regard. It is still leaking though. I'm sure you have seen that there's a leak in unmanaged memory happening at xul.dll. So this is an issue with Xulrunner itself or the way GeckoFX is handling COM. I am still investigating this as it is quite tricky (one of the reasons I absolutely hate .NET and managed code in general..I'm a C++/asm person). I also checked previous versions of Xulrunner/GeckoFX and compiled GeckoFX from source to 4.5.1 .NET just in case. Now I'm hunting in GeckoFX and Xulrunner code but due to me being unfamiliar with their source it's taking far more time than it should. Unfortunately later versions of Xulrunner can not be used due to GeckoFX. If I can't find it and patch GeckoFX/Xulrunner, I'll replace the GeckoFX/Xulrunner altogether.

I would also appreciate if Cyrealkiller would hand off the original source if he's done maintaining this since the decompiled code loses quite a bit of information. In particular having the original Visual Studio designer files would make changing the UI so much easier and having the comments would be nice.

I am guessing you are using ANTS decompiler as well. So I'll tell you how to fix the UI designer files. I spent a couple of hours doing that.

ANTS generates some code that Designer doesn't like. Specifically:

Multiple uses of point2 and size2:

ANTS first defines point2 then uses code like this for every element:

point2 = new Point(152, 201);
this.txtStatSlot6.Location = point2;

This needs to change into single direct instances like this:
this.txtStatSlot6.Location = new Point(152, 201);

Same for size.

Now the second and most time consuming fix is that it makes "internal virtual" properties of all UI elements and defines event handling (for those controls with events) inside them. The problem is that Designer expects all those properties to be fields and not properties. So you need to change them all by hand to "private" (or plain "internal" fields for those than need to be accessible by the assembly, outside the class (eg "browser") -- have not seen any that need to be internal virtual as I can see no subclass that tries to override them anywhere in the code) and comment the property code inside the braces. Once you do this for all the control properties the Designer will properly load the file. Once it does, use the commented property code for each field to see what events to assign to each field in the Designer. Once you do that, you'll have proper UI Designer files and you can get rid of the commented property code and you'll have a fully functional source.

You will also have to fix SetProcessWorkingSetSize() in Antimemoryleaks.cs so that it is under a NativeMethods class because that function tampers with unmanaged memory. Although the use of this function was probably a desperate attempt at trying to trim the working set. It doesn't actually help with the xul.dll leak but it will keep the working set to a minimum.

I will get back to you once I know more about the Xulrunner leak. Free time is a bit hard to squeeze these days as I'm currently into the process of launching a monster C++ application that I'm developing for a big company. But I'm actively working on this on spare time. I will get to the bottom of the leak or replace the web browser control entirely if it seems like a dead end.

hello there,
which decompiler do you use ? i tried decompling this EXE but i get mainly assembly language code (which i understand but this is really uggly)

I am using ANTS but if you don't have access to that you can always use ILSpy which is just as strong and open source.

[alklas]

/clap

impressive work.

[coondog27]

I am guessing you are using ANTS decompiler as well. So I'll tell you how to fix the UI designer files. I spent a couple of hours doing that.

Thanks, this was helpful advice. I've got my designer files working now just need to sort through the events to make sure I'm registering them as they were before.

Now the second and most time consuming fix is that it makes "internal virtual" properties of all UI elements and defines event handling (for those controls with events) inside them.

Yeah this has been fun lol. I am so happy RedGate decided to decompile this stuff in a way that the VS designer would never load it. Thanks again.

[Methuselas]

Sorry, I've been out for a bit. Just caught up on the thread. CK emailed me a month or two ago, asking for access to my account for beta testing. I got a bit wary and never responded ( I have too many Heroes and Adventurers, plus other Professionals I wasn't ready to risk losing). If you guys need it, I have Dragonne's original source. The lady and I were planning on trying to clean up the original, but it's obvious your coding abilities far surpass mine and hers. If you would like to get access to the original source, just shoot me a PM with your email and I'll send it to you.

[Insignis86]

I do appreciate your attempt to be helpful, however I am not having any luck searching the thread or your posts in this forum and have not found a post of yours with the link yet , and I have checked the website of the script for a post of yours with info! I have since reviewed your posts a third time, however did notice I was missing the link because the font and color were not indicative of a link the one post you have. Also when I previous clicked your name and viewed your posts in that list it did not link to anything until I actually clicked the post and entered it. So please instead of being rude be a little less critical and more understanding that not everyone is you and has the same computer setup as you.

TBH it is not my problem you didn't saw old post with link to the script. It is also not my problem you didn't spot link to discussion thread where the modded scripts paste-bins that give the multi-char capabilities are. Also it is not my problem you had issues understanding more or less simple information given in my posts.

I put link in brackets with text 'here' - which I suppose most people would understand was a link to mentioned discussion thread on script forum. On my, mentioned by you, computer setup it is completely black and doesn't differ from normal text, and yet somehow I know I should probably hover the mouse over it as it is maybe a link 'cause what else it could have been XD?

I even mentioned that my nick there is different (by saying multi-character was mainly my work with 'Eversor' the nick in brackets). But even if I didn't say it - if you would read that linked thread you would probably figure it out that my nick there is different as you would find the multi-char paste-bin post thou written by Eversor not Insignis. Then I probably shouldn't bash you for this if you failed with opening the link in the first place :P.

IIRC in that linked discussion under my different nick there I more or less said how multi-character support works. There are even some discussions about it being a bit rough - that it could be done maybe more clean/easy but I chose to go this route (relog on each char change) 'cause it helped me personally with few issues that simpler way (link/html) wouldn't. But again you wouldn't read it if you didn't open the link.

All in all I don't find myself being rude here, but rather you saying I'm rude 'cause you failed to find something or read something which on my end looked like you did not give a f**k to move a finger/use brain and just wanted to get everything you need on a silver platter. Also you didn't answer why you wrote that linked topic like its your own script which is also rude :P.

Anyway if I seemed rude in old posts it was not my intention, thou I'm not certain I care about that in this post ;]. Also I wish you all luck with both bots and scripts as I am no longer playing NWO (to damn boring) and thus I no longer pay attention to them.

[BaseN]

Thanks, this was helpful advice. I've got my designer files working now just need to sort through the events to make sure I'm registering them as they were before.

No problem

Yeah this has been fun lol. I am so happy RedGate decided to decompile this stuff in a way that the VS designer would never load it. Thanks again.

To be entirely fair it's not actually their fault. While decompiling they have no way of knowing if an element is a field or a property and because of object oriented design they default to making properties out of everything instead of making fields (which is the correct approach on a OOP language). One way around it would be to do post processing and detect the code is supposed to be UI Designer code, and parse and fix this afterwards. This could be tricky though as post processing could actually mess things up while only directly translating code produces code that compiles and works as it should anyhow. The downside is Designer doesn't like that heh.

Sorry, I've been out for a bit. Just caught up on the thread. CK emailed me a month or two ago, asking for access to my account for beta testing. I got a bit wary and never responded ( I have too many Heroes and Adventurers, plus other Professionals I wasn't ready to risk losing). If you guys need it, I have Dragonne's original source. The lady and I were planning on trying to clean up the original, but it's obvious your coding abilities far surpass mine and hers. If you would like to get access to the original source, just shoot me a PM with your email and I'll send it to you.

PM sent. This would really help me clean up the code faster as working with the decompiled source is kinda messy. I'm currently cleaning up all VB.NET traces from the decompiled source to make it C# only. The original source would help me clean up everything a lot faster so I can focus on fixes and changes

[Methuselas]

PM sent. This would really help me clean up the code faster as working with the decompiled source is kinda messy. I'm currently cleaning up all VB.NET traces from the decompiled source to make it C# only. The original source would help me clean up everything a lot faster so I can focus on fixes and changes

Okay, it's in your mailbox.

In the meantime, guys (and gals - no chauvinists we!), APB 1.5.0 runs solid, albeit it won't use additional assets. Been running it off and on since October. Went back to it, in November, when CK dropped beta testing. If you have it, use it. If you don't have it and want it, I'll post a link or something to it, but you should be able to find it in the old thread.

[cdmichaelb]

Is there an advantage to using this over userscripts? It seems to me that it's a bunch of unnecessary bulk. But I'm not really too proficient with userscript (javascript) so I don't know any better. Just curious.

[Roltan]

PLZ people, help!! somebody solved the problem with Russian gateway.nw.ru.perfectworld.eu ????

[gjggehbyfrhsit]

PLZ people, help!! somebody solved the problem with Russian gateway.nw.ru.perfectworld.eu ????

А нафига? Для своей помойки делайте сами.

[alklas]

Hello,

can you provide an updated release, with less memory leaks ?
because curently there are some many, that the programm gets stuck several times per day.

thanks