Did you know that PaintWorld(layer) is called twice?

[JarJarD3]

Just for those that want to "optimize" their code, I ques.

I found that only MonsterPackPlugin does check which layer to use.

if (layer != WorldLayer.Ground)
    return;

All other plugins execute their PaintWorld method twice, or I did not understand this at all.
For those plugins that draw both on world map and mini map this is of course convenient!

[KillerJohn]

yes, it does, but it is by design, because each decorator has a "Layer" property.

public class MonsterRiftProgressionColoringPlugin : BasePlugin, IInGameWorldPainter
{
public void PaintWorld(WorldLayer layer)
{
.......
decorator.Paint(layer, monster, monster.FloorCoordinate, monster.SnoMonster.NameLocalized);
}
}

you can see? it passes the layer to the decorator (which is a WorldDecoratorCollection)
WorldDecoratorCollection.Paint iterates through all decorators which belongs to the given layer and paints only those

this way you don't have to separate your painter into two methods, but allow the same PaintWorld method be called twice, and let the automagic decide which decorator will be used

[JarJarD3]

yes, it does, but it is by design, because each decorator has a "Layer" property.

public class MonsterRiftProgressionColoringPlugin : BasePlugin, IInGameWorldPainter
{
public void PaintWorld(WorldLayer layer)
{
.......
decorator.Paint(layer, monster, monster.FloorCoordinate, monster.SnoMonster.NameLocalized);
}
}

you can see? it passes the layer to the decorator (which is a WorldDecoratorCollection)
WorldDecoratorCollection.Paint iterates through all decorators which belongs to the given layer and paints only those

this way you don't have to separate your painter into two methods, but allow the same PaintWorld method be called twice, and let the automagic decide which decorator will be used

Yes, I understand that this is by design and for convenience.
And it is good but I have seen here code from people that do not understand programming so well as we
I just wanted to point out that you might want to optimize your code sometimes?

[RNN]

It is good to know this. The plugins that use decorators that apply only to Ground can prevent Paintworld from being processed twice unnecessarily by adding
if (layer != WorldLayer.Ground) return;

[RNN]

It is curious that this can be done to prevent PaintWorld from being processed twice, in plugins containing many instructions it can save a lot of processing time.

Code to express the idea, it is not functional:

		public WorldDecoratorCollection Decorator { get; set; }
		public void PaintWorld(WorldLayer layer)
		{
			Decorator.Paint(layer, actor, actor.FloorCoordinate, null);
		}

replaced by this

		public WorldDecoratorCollection Decorator { get; set; }
		public void PaintWorld(WorldLayer layer)
		{
			if (layer != WorldLayer.Ground) return;
			Decorator.Paint(layer, actor, actor.FloorCoordinate, null);
			Decorator.Paint(WorldLayer.Map, actor, actor.FloorCoordinate, null);
		}