[v7.6] [ENGLISH] [Arkahr] NoGemsPlugin

[JarJarD3]

JarJar -- I tested your new modified version and it works fine except the Legacy Of Dreams gem. That one is still not seen by plugin. The other ones seem to be working fine. If you take a gem out the popup shows and once back in goes away. Legacy Of Dreams makes no difference always have popup of no gem.
I noticed KillerJhon mention in a reply to you on a different post about the gem. He said he had forgot to re-generate the interface files for hud. I have no idea if that is the case. Just mentioning here if that might be the case.
I did try this on the latest beta build as well ( TurboHUD 19.8.29.1 (v9.1) BETA ). Same difference, still not seen. Thanks for trying to update the plugin.

It seems that LegacyOfDreamsPrimary SNO number is not correct in THUD ISnoPowerList interface definition (my version is 19.8.26.3).
I tested with below code and it seems that the SNO number is 446565 - not 483319.

It worked when I submitted it and have't tested since I don't use LoD now in any of my builds. Must have changed somewhere between then and now.

So I patched the function to get all active GEM buff again
And pastebin for you convenience.

        private static IEnumerable<IBuff> ActiveGemPrimaryBuffs(IPlayer player)
        {
            var gems = player.Powers.UsedLegendaryGems;
            var buffs = new IBuff[]
            {
                gems.BaneOfThePowerfulPrimary,
                gems.BaneOfTheStrickenPrimary,
                gems.BaneOfTheTrappedPrimary,
                gems.BoonOfTheHoarderPrimary,
                gems.BoyarskysChipPrimary,
                gems.EnforcerPrimary,
                gems.EsotericAlterationPrimary,
                //gems.GemOfEasePrimary,            // Ignore in this context.
                gems.GemOfEfficaciousToxinPrimary,
                gems.GogokOfSwiftnessPrimary,
                gems.IceblinkPrimary,
                gems.InvigoratingGemstonePrimary,
                //gems.LegacyOfDreamsPrimary,
                player.Powers.AllBuffs.FirstOrDefault(x => x.SnoPower.Sno == 446565),   // P4_ItemPassive_Unique_Ring_034
                gems.MoltenWildebeestsGizzardPrimary,
                gems.MoratoriumPrimary,
                gems.MirinaeTeardropOfTheStarweaverPrimary,
                gems.MutilationGuardPrimary,
                gems.PainEnhancerPrimary,
                //gems.RedSoulShardPrimary,         // Ignore in this context.
                gems.SimplicitysStrengthPrimary,
                gems.TaegukPrimary,
                gems.WreathOfLightningPrimary,
                gems.ZeisStoneOfVengeancePrimary,
            };
            foreach (var buff in buffs)
            {
                if (buff != null && buff.Active)
                    yield return buff;
            }
        }

[Silkdog569]

I did tested again and still had no luck. Legacy gem is still not recognized as being equipped. I used the 19.8.26.3 version and the 19.8.29.1 beta and had same popup as not seeing the gem. I did download the one you posted and tried that as well same issue popup of missing gem. I double check my plugins just to make sure I had no other plugins in conflict with legendary gems and did not find any. Will have to wait for the sno code to be corrected I guess. I thank You again for trying to help out on this. I did update Jacks extensions on my own plugin folder with correct information for the gem but again same popup of missing gem. I think untill the sno id code is correct either way will not work.
Thank You again for trying to help out with this plugin.

[dalmi]

thanks for the experiment, but here the same - the new gem is not recognized. hope there will be a solution soon - thank you all for the good plugins

[JarJarD3]

thanks for the experiment, but here the same - the new gem is not recognized. hope there will be a solution soon - thank you all for the good plugins

I don't get it as it works for me!
I'm using version 19.8.26.3 and plan to stay here until I see a reason to update.

When I implemented Legacy Of Dreams Primary "hack" the original values were SNO 483320 code "ItemPassive_Unique_Gem_023U_x1" that worked for me (or I tested it wrong way).
Now it seems to be SNO 446565 code "P4_ItemPassive_Unique_Ring_034" (or I tested it wrong way).
So there is some confusion somewhere and I assume that D3 binary is the same all the time. But can not verify that.

[JarJarD3]

I don't get it as it works for me!
I'm using version 19.8.26.3 and plan to stay here until I see a reason to update.

When I implemented Legacy Of Dreams Primary "hack" the original values were SNO 483320 code "ItemPassive_Unique_Gem_023U_x1" that worked for me (or I tested it wrong way).
Now it seems to be SNO 446565 code "P4_ItemPassive_Unique_Ring_034" (or I tested it wrong way).
So there is some confusion somewhere and I assume that D3 binary is the same all the time. But can not verify that.

This gem is a bit problematic as it can not be detected in the conventional way if its buff is not active.
Original fix I submitted works and now I tested it without legendary items.
If you equip set items and have their buff on then NoGemsPlugin thinks that the gem is not equipped.

So this original fixed hack should work, if used correctly.
Do not use set items with Legacy Of Dreams gem!

NoGemsPlugin plugins works indirectly to query active buffs for gems that can be socketed because "reading" gems from jewelry sockets is unreliable and does not work all the time.
This can be easily verified as sometimes gem rank is missing or not updated after you level the gem up few ranks.
Legacy Of Dreams gem is an exception as it can be equipped (socketed) and still inactive thus remaining undetected.

[JarJarD3]

Again I shamelessly advertise my own plugin in "competitors" thread.
I updated my CheckMissingItems ([INTL][JarJar]CheckMissingItems) plugin to include a warning when Legacy Of Dreams is equipped but not active.

Here is side by side comparison how these two plugins report now.

[BeeAntOS]

Follow the update instructions of LegendaryGemInfoExtensions.cs by @iThinkiWin ([INTERNATIONAL] [Prrovoss] PartyInspector) for workaround.

[Silkdog569]

JarJar, Thanks for the explanation on the gem. I did not realize it worked that way. Your initial fix worked fine. My apologizes for saying it did not work.
For people who still want to use this plugin you will need to replace these two files in Jacks extensions. JackExtensions.zip unzip files and place and or copy over files into \plugins\Jack\Extensions
This will fix the No Gem Plugin if using the Legacy Of Dreams gem correctly.