This is a guide that helps you choosing the best class-race combination that fits you the most and is the most effective. Ive been using it lately when making new chars (pre-TBC, no Draenei or Belf, so some info might be a little inacurate).
Link: Choosing Your Best Class and Race in World of Warcaft
Have fun ^^