Results 1 to 7 of 7
  1. #1
    Sergeant Major
    Reputation
    46
    Join Date
    Feb 2008
    Posts
    167
    CoreCoins
    111

    Trade Feedbacks

    Status
    n/a
    Positive
    0 (0%)
    Negative
    0 (0%)

    need help fixing crashing hooks



    Donate to Remove Ads, Get ShoutBawx - Elite Forum Access
    I seem to have a problem with my hooks. Itīs all working fine on my computers, while itīs always crashing for a friend of mine.

    Iīm sorry to not provide the error message. I will edit this post, if he manages to send it to me.

    the hook gets hit, my hook function gets executed, but it crashes when calling the backed up code. and i donīt understand why.
    maybe i overlooked something obvious.

    here is the log with the dumped hook:

    Code:
    01/20/12 17:56:04   DEBUG_1   Hook :  Creating and applying LoadLibraryA hook
    01/20/12 17:56:04   DEBUG_4   applyDetour : Dumping SafeSpot before modification: 
    0x775e4bc6  mov edi, edi
    0x775e4bc8  push ebp
    0x775e4bc9  mov ebp, esp
    0x775e4bcb  cmp dword ptr [ebp+08h], 00000000h
    0x775e4bcf  push ebx
    0x775e4bd0  push esi
    0x775e4bd1  push edi
    
    01/20/12 17:56:04   DEBUG_4   applyDetour : Dumping backed up instructions  before modification: 
    0x388d00  mov edi, edi
    0x388d02  push ebp
    0x388d03  mov ebp, esp
    0x388d05  cmp dword ptr [ebp+08h], 00000000h
    
    01/20/12 17:56:04   DEBUG_4   applyDetour : Dumping backed up instructions after fixing relative Instructions: 
    0x388d00  mov edi, edi
    0x388d02  push ebp
    0x388d03  mov ebp, esp
    0x388d05  cmp dword ptr [ebp+08h], 00000000h
    0x388d09  jmp 775E4BCFh
    
    01/20/12 17:56:04   DEBUG_4   applyDetour : Dumping Hooked Function 
    0x775e4bc6  push 70F913DCh
    0x775e4bcb  ret 
    0x775e4bcc  nop 
    0x775e4bcd  nop 
    0x775e4bce  nop 
    0x775e4bcf  push ebx
    0x775e4bd0  push esi
    0x775e4bd1  push edi
    
    01/20/12 17:56:04   DEBUG_1   DllMain returning
    01/20/12 17:56:04   DEBUG_1   myLoadLibrary :  calling original LoadLibraryA at 0x388d00 with kernel32.dll

    Code:
    typedef HMODULE (WINAPI* 	 tLoadLibrary)(const char * c);
    tLoadLibrary 	g_oLoadLibrary = nullptr;
    
    HMODULE WINAPI myLoadLibrary(const char * c)
    {
    	std::string s = c;
    	HMODULE hMod = NULL;
    
    	DBG << FKT << " calling original LoadLibraryA at " << (void*)g_oLoadLibrary << " with " << s << std::endl;
    
    	hMod = g_oLoadLibrary(c); // <------- Crashing....

  2. #2
    Contributor
    Reputation
    144
    Join Date
    Nov 2009
    Location
    Germany
    Posts
    380
    CoreCoins
    164

    Trade Feedbacks

    Status
    n/a
    Positive
    0 (0%)
    Negative
    0 (0%)
    Did you check memory page protection flags? Is your generated code executable?

  3. #3
    Sergeant Major
    Reputation
    46
    Join Date
    Feb 2008
    Posts
    167
    CoreCoins
    111

    Trade Feedbacks

    Status
    n/a
    Positive
    0 (0%)
    Negative
    0 (0%)
    iīm just allocating the momeory with new. i assumed it should be accessible afterwards without problems.
    should i manually set the rights?

    here is what i do:

    Code:
    /**
     *  Asm Stuff
     */
    #pragma pack(1)
    class Instruction
    {
    public:
    	char 			opcode;
    };
    #pragma pack()
    
    #pragma pack(1)
    class AsmJmp : public Instruction
    {
    public:
    	void Apply(unsigned long addr)
    	{
    		opcode = 0xE9;
    		relativeAddr = addr;
    	}
    	unsigned long 	relativeAddr;
    };
    #pragma pack()
    
    
    void* CPatchDetour::applyDetour(void *pTarget, void *pHook)
    {
    	size_t cpySize = 0;
    	char* pSrc = reinterpret_cast<char*>(pTarget);
    
    	pSrc = findSafeSpot(pSrc);   // working as intended
    	m_pTarget = pSrc;
    
    	cpySize = getNeededSize(pSrc); // working as intended
    	m_Len = cpySize;
    
    	LOG_(log_debug4) << FKT  << "Dumping SafeSpot before modification: " << std::endl
    					 << toAsmString(pSrc,cpySize) 				  		<< std::endl;
    
    	// allocate mem and backup original instructions
    	m_pOriginal = std::tr1::shared_ptr<char>(new char[cpySize + size_jmp]);
    	memcpy(m_pOriginal.get(), pSrc , cpySize);         // looking at log seems to write stuff as intended
    
    
    	LOG_(log_debug4)  << FKT  << "Dumping backed up instructions before modification: " << std::endl
    					  << toAsmString(m_pOriginal.get(),cpySize) 			<< std::endl;
    
    
    	fixRelativeInstructions(m_pOriginal.get(), pSrc ,cpySize);     // working as intended
    
    	// append jump back to Target Instruction
    	reinterpret_cast<AsmJmp*>( cpySize + m_pOriginal.get() )
    			->Apply( (DWORD)pSrc - (DWORD)(m_pOriginal.get() + size_jmp)  );   // looking at log seems to also write what itīs supposed to do
    
    
    	LOG_(log_debug4)  << FKT  << "Dumping backed up instructions after fixing relative Instructions: " << std::endl
    					  << toAsmString(m_pOriginal.get(),cpySize) 				   		   << std::endl;
    
    
    	setupHook(pSrc, cpySize, (char*)pHook);  // also working
    
    
    	LOG_(log_debug4)  << FKT  << "Dumping Hooked Function " << std::endl
    					  << toAsmString(pSrc,cpySize)  		<< std::endl;
    
    
    	return m_pOriginal.get();
    }
    
    void CPatchDetour::setupHook(char* pTarget, size_t size, char* pHook)
    {
    	// write our Hook code to target function
    	VirtualProtectBlock tarProtect(pTarget, size, PAGE_EXECUTE_READWRITE );
    
    	// write push addr ret
    	reinterpret_cast<AsmPushRet*>(pTarget)
    			->Apply((unsigned long)pHook);
    
    	// nop the rest
    	for( size_t i = size_push_ret; i < size ; i++)
    	{	// nop the rest
    		reinterpret_cast<char*>(pTarget)[i] = 0x90; //nop
    	}
    }
    ugly, but doing the job, at least on my machine and i donīt want to rewrite till i know whatīs wrong.

  4. #4
    Sergeant Major
    Reputation
    46
    Join Date
    Feb 2008
    Posts
    167
    CoreCoins
    111

    Trade Feedbacks

    Status
    n/a
    Positive
    0 (0%)
    Negative
    0 (0%)
    you seem to be right. the region only got readwrite access


    01/30/12 12:23:59 DEBUG_4 dumpHook : Protection backed up instr:
    BaseAddress: 0x548000
    AllocationBase: 0x540000
    AllocationProtec: 4
    RegionSize: 4096
    State: 4096
    Protect: 4
    Type: 131072

    this dump is from my computer. but iīm a little bit confused, why itīs crashing on his pc but not on my...
    iīll wait till he gets online, so he can try with adjusted access.

    edit:
    after reading up on msdn and turning on dep support in bios i was finally able to reproduce the error.

    big thanks for pointing me in the right direction!
    Last edited by boredevil; 01-30-2012 at 07:07 AM.

  5. #5
    Kynox's Sister's Pimp Cypher's Avatar
    Reputation
    1352
    Join Date
    Apr 2006
    Location
    ntdll.dll
    Posts
    5,352
    CoreCoins
    181

    Trade Feedbacks

    Status
    n/a
    Positive
    0 (0%)
    Negative
    0 (0%)
    Don't allocate memory for your hook and/or trampoline with 'new'. Use VirtualAlloc/VirtualAllocEx with the correct page flags (PAGE_READWRITE when you're setting up your hook, then PAGE_EXECUTE once the data is written and you're ready to detour your target function). Not only will that fix your DEP problem, but it will mean you're not opening up a security hole in your application (protection flags are set with a page-level granularity, so you may be modifying - and 'relaxing' from a security perspective - the flags of memory that you don't 'own'!).

    (If you're going to be setting lots of hooks you're probably going to want to use the same page for multiple hooks, but if you're only setting one or two it's probably easier to just use a page per hook.)

    EDIT:

    To make it clear, you obviously don't want to 'solve' this problem by requiring DEP to be disable for the target process. Too many people do that, please don't join them or I'll have to hate you. VirtualProtect is your friend!

  6. #6
    Sergeant Major
    Reputation
    46
    Join Date
    Feb 2008
    Posts
    167
    CoreCoins
    111

    Trade Feedbacks

    Status
    n/a
    Positive
    0 (0%)
    Negative
    0 (0%)
    thanks for the explanation.

    turning off dep wasnīt an option after reading up on it. i wondered, why itīs not enabled by default in my bios.
    i fixed it using VirtualProtect to set the correct protection.
    what you say about VirtualAlloc seems pretty reasonable. going to read up on it now and rewrite stuff.

  7. #7
    Kynox's Sister's Pimp Cypher's Avatar
    Reputation
    1352
    Join Date
    Apr 2006
    Location
    ntdll.dll
    Posts
    5,352
    CoreCoins
    181

    Trade Feedbacks

    Status
    n/a
    Positive
    0 (0%)
    Negative
    0 (0%)
    Quote Originally Posted by boredevil View Post
    thanks for the explanation.

    turning off dep wasnīt an option after reading up on it. i wondered, why itīs not enabled by default in my bios.
    i fixed it using VirtualProtect to set the correct protection.
    what you say about VirtualAlloc seems pretty reasonable. going to read up on it now and rewrite stuff.
    Yes, please use VirtualAlloc instead of 'new'. Making the heap executable is bad mojo.

 

 

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
All times are GMT -4. The time now is 12:41 AM. Powered by vBulletin® Version 4.2.0
Copyright © 2014 vBulletin Solutions, Inc. All rights reserved.
Content Relevant URLs by vBSEO Resources saved on this page: MySQL 5.88%
vBulletin Optimisation provided by vB Optimise (Pro) - vBulletin Mods & Addons Copyright © 2014 DragonByte Technologies Ltd.
Digital Point modules: Sphinx-based search

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160