-
Member
Your prot warrior rotation has a typo in regards to handling shield barrier.
You have
Code:
{ "Shield Barrier", {
"!player.buff(Shield Barrier)",
(function() return NeP.Core.dynamicEval("player.rage <= " .. NeP.Core.PeFetch('NePConfigWarrProt', 'ShieldBarrier')) end)
}},
Which makes no sense because it means use Shield barrier when rage is LESS or Equal to setting. It should be >=. To indicate when rage is MORE than say 80. THEN use Barrier.
Most likely from sloppy copypasta job because all the previous survival cd uses health, which you would use less than/equal to pop a CD.
-
Contributor
Originally Posted by
Lightbrand
Your prot warrior rotation has a typo in regards to handling shield barrier.
You have
Code:
{ "Shield Barrier", {
"!player.buff(Shield Barrier)",
(function() return NeP.Core.dynamicEval("player.rage <= " .. NeP.Core.PeFetch('NePConfigWarrProt', 'ShieldBarrier')) end)
}},
Which makes no sense because it means use Shield barrier when rage is LESS or Equal to setting. It should be >=. To indicate when rage is MORE than say 80. THEN use Barrier.
Most likely from sloppy copypasta job because all the previous survival cd uses health, which you would use less than/equal to pop a CD.
Thanks, will change that.
Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Liberty nor Safety.
-
Member
Any news on if you're gonna make a Warrior Arms rotation?
-
Contributor
Originally Posted by
Morl0ck
Any news on if you're gonna make a Warrior Arms rotation?
Would be hard considering i dont currently have a account :P
I can build some "bone work" on the dark, and if someone is insterested in commiting to it.
PS: I'm around even tho im not actively pushing commits, pull requests are accepted.
Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Liberty nor Safety.
-
Member
I've been trying to toy around improving the warrior prot gladiator part by consulting Gladiator Warrior DPS Rotation, Cooldowns, and Abilities (WoD 6.2.2) - Icy Veins
This is what I've come up with so far, does this make any sense? Can it be improved upon? I have no experience in coding and I'm pretty much just using the documentation and looking at other code trying to piece something together
I'm trying to incorporate Unyielding Strikes as well (as you can see in my code snippet), one thing I can think off on top of my head is making Devastate the top prio if Unyielding Strikes count is less then 6 and it's the last global cooldown before they run out but I have no idea how to do that.
Code:
local inCombat_Gladiator = {
{ "Heroic Strike", "player.buff(Unyielding Strikes).count >= 4" },
{ "Shield Charge", "!player.buff(Shield Charge)" },
{ "Shield Charge", "spell(Shield Charge).charges >= 2" },
{ "Heroic Strike", "player.buff(Shield Charge)" },
{ "Heroic Strike", "player.rage >= 95" },
{ "Devastate", "player.buff(Unyielding Strikes).count <= 5" },
{ "Shield Slam", "player.buff(Shield Charge)" }, --is this redundant?
{ "Revenge", "player.buff(Shield Charge)" },
{ "Devastate", "player.buff(Shield Charge)" },
{ "Shield Slam" },
{ "Revenge" },
{ "Execute" },
{ "Devastate" }
}
Last edited by Kladdkakan; 09-19-2015 at 11:53 AM.
Reason: fixed Heroic Strike and Devastate Unyielding Strike count
-
Contributor
Originally Posted by
Kladdkakan
I've been trying to toy around improving the warrior prot gladiator part by consulting
Gladiator Warrior DPS Rotation, Cooldowns, and Abilities (WoD 6.2.2) - Icy Veins
This is what I've come up with so far, does this make any sense? Can it be improved upon? I have no experience in coding and I'm pretty much just using the documentation and looking at other code trying to piece something together
I'm trying to incorporate Unyielding Strikes as well (as you can see in my code snippet), one thing I can think off on top of my head is making Devastate the top prio if Unyielding Strikes count is less then 6 and it's the last global cooldown before they run out but I have no idea how to do that.
Code:
local inCombat_Gladiator = {
{ "Heroic Strike", "player.buff(Unyielding Strikes).count >= 4" },
{ "Shield Charge", "!player.buff(Shield Charge)" },
{ "Shield Charge", "spell(Shield Charge).charges >= 2" },
{ "Heroic Strike", "player.buff(Shield Charge)" },
{ "Heroic Strike", "player.rage >= 95" },
{ "Devastate", "player.buff(Unyielding Strikes).count <= 5" },
{ "Shield Slam", "player.buff(Shield Charge)" }, --is this redundant?
{ "Revenge", "player.buff(Shield Charge)" },
{ "Devastate", "player.buff(Shield Charge)" },
{ "Shield Slam" },
{ "Revenge" },
{ "Execute" },
{ "Devastate" }
}
No, that Shield Slam is not redudant.
Notice it gives priority to Shield Slam instead of Revenge or Devastate if you have the shiled charge buff.
Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Liberty nor Safety.
-
Member
Originally Posted by
MrTheSoulz
No, that Shield Slam is not redudant.
Notice it gives priority to Shield Slam instead of Revenge or Devastate if you have the shiled charge buff.
Aight, do you have any other suggestions on how to improve it or maybe include the suggested Devastate change? Thanks for all your hard work!
-
Contributor
Originally Posted by
Kladdkakan
Aight, do you have any other suggestions on how to improve it or maybe include the suggested Devastate change? Thanks for all your hard work!
i cant help much without in-game acess but...
"one thing I can think off on top of my head is making Devastate the top prio if Unyielding Strikes count is less then 6 and it's the last global cooldown"
{{-- wait for spells
{ "Devastate", "player.buff(Unyielding Strikes).count < 6" }
}, {
-- Insert all spells to wait for here.
"player.spell(#ID).cooldown <= #", -- 1st cooldown
"player.spell(#ID).cooldown <= #", -- 2st cooldown
"player.spell(#ID).cooldown <= #", -- 3st cooldown
} },
Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Liberty nor Safety.
-
Member
Originally Posted by
MrTheSoulz
i cant help much without in-game acess but...
"one thing I can think off on top of my head is making Devastate the top prio if Unyielding Strikes count is less then 6 and it's the last global cooldown"
{{-- wait for spells
{ "Devastate", "player.buff(Unyielding Strikes).count < 6" }
}, {
-- Insert all spells to wait for here.
"player.spell(#ID).cooldown <= #", -- 1st cooldown
"player.spell(#ID).cooldown <= #", -- 2st cooldown
"player.spell(#ID).cooldown <= #", -- 3st cooldown
} },
I'll play around some and see if I can put something together. Appears the spellid for global cooldown is 61304 in case anyone else wants to toy around with GCD
-
Member
I do all from "how to instal". When i login and put char (Paladin Retr) it downlod routing but after 'No unlock found, now in FaceRoll mod. Help pls
-
Contributor
Originally Posted by
tork35
I do all from "how to instal". When i login and put char (Paladin Retr) it downlod routing but after 'No unlock found, now in FaceRoll mod. Help pls
You require a lua unlocker,
Free: EWT or oLua
Paid: FireHack (Recommended (Not sure if i can post a link for it here, but you can easly find it in google))
Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Liberty nor Safety.
-
Member
do you need a month subscription mrthesoulz? i can get you one if you want.
-
Post Thanks / Like - 1 Thanks
MrTheSoulz (1 members gave Thanks to mikedarling905 for this useful post)
-
Contributor
Originally Posted by
mikedarling905
do you need a month subscription mrthesoulz? i can get you one if you want.
I could use it on a alt account if your willing to
Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Liberty nor Safety.
-
Post Thanks / Like - 1 Thanks
svs (1 members gave Thanks to MrTheSoulz for this useful post)
-
Member
Rogues no longer have instant poison, so the code should be
Code:
-- Poison's
-- Letal
{"Deadly Poison", {
"!lastcast(Deadly Poison)",
"!player.buff(Deadly Poison)"
}},
-- Non-Letal
{"Crippling Poison", {
"!lastcast(Crippling Poison)",
"!player.buff(Crippling Poison)"
}},
}
Or wound, or if there should be a toggle.
-
Member
Hi i just installed the latest version of your rotations -- wich are great and ty
But when i try to enter the disc priest class setting it say : Sorry this spec does not have a GUI yet