PQR - Rotation Bot

[crystal_tech]

InteractRange = CheckInteractDistance("target", 3)

Would 0 be melee?

Example

InteractRange = CheckInteractDistance("target", 0)

if InteractRange and ArtOfWar ~= nil then
return true
end

What does 1, 2, 3 stand for with interactDistance?

some fights are bugged with interactDistance and i've tried switching to

PQR_UnitDistance(unit1, unit2)
  -- Returns the distance in yards from unit1 center to the center of the unit2's hitbox. A players hitbox is about 3 yards, so a 40 yard spell can actually be cast when this returns 43... I am looking into taking this into consideration somehow. Accepts both GUID and unitID

only thing that it seems to work on (still playing with it) is in my demo lock code for felguard's felstorm.

[lostinthewoodslol]

wtb beta offsets for lvling to lvl 90 pls want donate this

same, will donate 100% xD

[Frissle]

same, will donate 100% xD

same, will donate 110% ^^

[dklcfr]

well how about we set the bar at $800
there $800 is 100% k go with your donations.

[Ralphiuss]

wtb beta offsets for lvling to lvl 90 pls want donate this

Just have to be patient. Xelper will get to it.

[Dominium]

Hey everyone!

I am in the process of upgrading Cokx Ret pally profile. So far added immunity checks, changed some keybinds, changed the Word of Glory code to better suit Selfless Healer and stuff like that. Now I started working on the most important thing (imo) - a Kill Function, similar (identical) to the one in Kaolla's UH DK PvP profile. However, I just can't get it to work. Here is the Kill Function code that I copied directly from Kaolla:

if not LeftControlKeyDown then LeftControlKeyDown = 0 end

if IsLeftControlKeyDown() and GetTime() - LeftControlKeyDown > 0.7 then
LeftControlKeyDown = GetTime()
if KillFunction then
KillFunction = false
PQR_WriteToChat("Kill Function: |cFF8C00FFDisabled", "Unholy PvP")
PQR_Event("PQR_Text", "Kill Function: Disabled", nil, "8C00FF")
else
KillFunction = true
PQR_WriteToChat("Kill Function: |cFF00FF00Enabled", "Unholy PvP")
PQR_Event("PQR_Text", "Kill Function: Enabled", nil, "00FF00")
end
end

Basically clicking Right Control enables/disables KillFunction. One thing that I find weird is that there's no local for the KillFunction?

Clicking Control does display that 'Kill Function enabled/disabled' however, when I start using KillFunction in my abilities... eg. here's Zealotry

local sDivinePurpose = UnitBuffID("player", 90174)


if KillFunction
and sDivinePurpose ~= nil then
//or UnitPower("player", 9) == 3
//and UnitBuffID("player", 31884) then
return true
end

/* if KillFunction ~= nil
and UnitPower("player", 9) == 3
and UnitBuffID("target", 31884) then
return true
end */

else
return false
end

As you can see I commented out a lot as I was trying to test it out, yet every time that I add the 'if KillFunction' I keep on being spammed by Lua Errors.

Message: [string "if PQR_Addon_Loaded == nil then..."]:736: attempt to call field '?' (a nil value)
Time: 07/16/12 07:48:32
Count: 828
Stack: [string "if PQR_Addon_Loaded == nil then..."]:736: in function `PQR_NextAbility'
[string "if PQR_Addon_Loaded == nil then..."]:532: in function `PQR_ExecuteRotation'
[string "if PQR_Addon_Loaded == nil then..."]:289: in function <[string "if PQR_Addon_Loaded == nil then..."]:214>

Locals: rotationNumber = 0
nextAbility = -1
playerChanneling = false
(for index) = 1
(for limit) = 1023
(for step) = 1
i = 1
spellID = 85696
skipUnknown = true
isSpellKnown = true
(*temporary) = nil
(*temporary) = "attempt to call field '?' (a nil value)"

Would be awesome if someone could help me out with this!

Cheers

[Frissle]

Just have to be patient. Xelper will get to it.

yeah. i believe so to

[Dominium]

Hmm, seems like something is wrong with my Zealotry code - I tested this out with AW and it worked. Weird, however, feeding time atm so Ill bb later.

[Dominium]

It's working! Finally! Will release my edit of Cokx profile today or tomorrow!

[averykey]

some fights are bugged with interactDistance and i've tried switching to

PQR_UnitDistance(unit1, unit2)
  -- Returns the distance in yards from unit1 center to the center of the unit2's hitbox. A players hitbox is about 3 yards, so a 40 yard spell can actually be cast when this returns 43... I am looking into taking this into consideration somehow. Accepts both GUID and unitID

only thing that it seems to work on (still playing with it) is in my demo lock code for felguard's felstorm.

Thanks

+rep when I can

Saw this in your demo
PlayerThreat = UnitThreatSituation("player", "target")

I would use this like so?

If PlayerThreat == 1 then
--cast hand of salv
end

And this would only cast when my threat was higher than the tanks.

I saw soulshatter was comparing to 3 instead of 1, why?
if EnemyExists and PlayerCombat then
if PlayerThreat == 3 and PQR_SpellAvailable(29858) then
return true
end
end

With otherunit specified
nil = unit is not on otherunit's threat table.
0 = not tanking, lower threat than tank.
1 = not tanking, higher threat than tank.
2 = insecurely tanking, another unit have higher threat but not tanking.
3 = securely tanking, highest threat
Without otherunit specified
nil = unit is not on any other unit's threat table.
0 = not tanking anything.
1 = not tanking anything, but have higher threat than tank on at least one unit.
2 = insecurely tanking at least one unit, but not securely tanking anything.
3 = securely tanking at least one unit.

What is wrong with my profile? I have looked through the code several times and I have not seen anything wrong.
Rep+ for help.

Buggrabber has not been useful, is there another lua error checking mod?


http://up.ht/NttG0n

[crystal_tech]

Thanks

+rep when I can

Saw this in your demo
PlayerThreat = UnitThreatSituation("player", "target")

I would use this like so?

If PlayerThreat == 1 then
--cast hand of salv
end

And this would only cast when my threat was higher than the tanks.

I saw soulshatter was comparing to 3 instead of 1, why?
if EnemyExists and PlayerCombat then
if PlayerThreat == 3 and PQR_SpellAvailable(2985 then
return true
end
end

soulshatter is a aggro drop so when your target has threat lvl of 3 it uses it cause the target is coming at you and you don't want that. lvl 2 would be offtank 3 would be tanking and 1 would be dps/heals on the aggro table for that target.

[Frissle]

It's working! Finally! Will release my edit of Cokx profile today or tomorrow!

Is it the PvP Profile for affli locks you are talking about? If so, what kind of improvements have you done to it?

[vitamincore]

Guys please help, really need a working profile for Feral PvP, Rogue PvP

[Dominium]

Alright, as I said, here is my version of Cokx Retribution Paladin PvP Profile.

Changes

1. HUGE quality-of-life improvement. Added something called the "Kill Function". If you ever used Kaolla's UH DK PvP profiles, you will know what it is.

Toggle: Left Control (Enable/Disable Kill Function)

Behavior: Casts Avenging Wrath (wings) when Zealotry is off CD + you got 3 Holy Power or Divine Purpose. Activates your +str trinket as well as Zealotry at the same time.

What's the difference between my Kill Function and Cokx way of using burst CDs? There you had to press the RIGHT shift button (how uncomfortable! clicked Enter instead of Shift a billion times) + you had to hold it down for it to activate wings/zealotry. Also, you had to watch your Holy Power and press Right Shift exactly at the moment when you got 3 Holy Power or the profile would only pop wings + trinket and then use the Holy Power for eg. TV without activating Zealotry.

In my opinion, this is a huge upgrade and makes it MUCH easier to use the profile.

2. Added immunity + CC checks to all attacks. Also special immunity checks (eg. Anti-Magic Shell check for HoW/Exorcism). No more attacking scattered/trapped/sapped/blinded etc. targets as well!

3. Added a Dark Simulacrum check. Depending on what's off CD it will either cast Holy Wrath or Hand of Reckoning (taunt) to get rid off Dark Sim. No wings/bubbles for you, DKs!

4. Took a bit of code from Averykey's ret PvE profile. Latency changer + Holy wrath + Judgement (Zealotry) + Titans Verdict logic with Divine Purpose and 2 holy power.

5. Added a instant flag return code for PvP Battleground purposes.

6. Added a HoW (Avenging Wrath) ability, that is lower in priority then Inquisition (so that when you are rushing in on someone with Kill Function on you will Wings, Trinket, Zealotry and then first Inquisition, then HoW (to increase HoW dmg by 30%). I kept the normal HoW above Inq in priority in case someone is about to die and you don't want to waste a global on Inquisition.

7. Edited the Word of Glory code to better suit Selfless Healer.

8. Changed Left Alt from a Repentance on Mouseover to a Rep on Focus. Too many times have I casted Rep on a wrong target because my mouse moved a bit too fast or something

9. Left Shift is now pause rotation. Hammer of Justice IS NO LONGER keybinded to the profile. (same reason as with Repentance + no more keys available on the left side of the keyboard ;p)


Suggested Macros/Keybinds

Here are some of the binds that I use that I would suggest you guys use. Note that since LEFT SHIFT is now Pause Rotation, binding spells to left shift + something is the best as you are guaranteed to cast that spell (rotation is paused).

a) Shift-G

#showtooltip Hammer of Justice
/cast [@focus,exists] Hammer of Justice; Hammer of Justice

Casts HoJ on Focus if you have a focus, on target if you don't have a focus. Very useful (bind it to whatever you want, but dont forget it should be with a Shift to pause rotation)

b) Got Guardian on 1 and Hand of Sacrifice ( [target=party1]) bound to 2. Guardian doesnt use a Global CD so it doesnt need a shift, you can put shift + something for Hand of Sac tho.

c) /cancelaura Hand of Protection
/cancelaura Divine Shield

Pretty useful. Bind it to whatever u want, shift isnt needed here.

d)
/focus
/focus [@mouseover,exists, nodead]

Focuses target if u have one, mouseover if u dont.

e) Shift-E Hand of Freedom ([target=MyCharName]) this is useful, as the profile only uses HoF on your party members that need it (you can use cleanse on yourself) however HoF is useful eg. during burst

f) /focus arena1 /focus arena2 (two separate macros) sometimes useful, so you dont have to mouseover anything

g) Almost forgot - remember to bind Hand of Protection (pref. on your team mate aka [target=party1] ) to Shift + something. VERY useful as the profile doesnt use HoP at all.

h) my mount macro - nothing to do with the profile, but, why not paste it here? ;P

/stopmacro [flying]
/cast [outdoors,nomounted,flyable] Spectral Gryphon; [outdoors,nomounted] Swift Lovebird
/dismount [mounted]

Uses the Gryphon if u can fly, uses the Lovebird in areas u cant (eg. Bgs/Arena)

My Glyphs/Talents

Prime
1. Templars Verdict
2. Judgement (you can also use Seal of Truth, expertise is very useful)
3. Word of Glory

Major
1. Turn Evil (must)
2. Hammer of Justice (very useful)
3. Hammer of Wrath (you use a TON of mana during burst)

Minor
1. Kings
2. Might
3. Truth


Talents

Talent Calculator - World of Warcraft (selfless healer spec)



Please help me by reporting any bugs that you find! If you guys enjoy this profile, I would be happy to take over Cokx ret pally profile for MoP if he doesn't come back!

DOWNLOAD LINK

Cheers and happy owning!


PS.

I highly suggest using the PQInterface addon, it shows when Kill Function is enabled and when it's disabled, SUPER useful!!

[katuro]

yes i do mate

what version of pqr are you using.

i updated nova's profiles using this link on bu_ba's account.
http://bubba-pqr-profiles.googlecode...a_Profiles.txt

is it meant to say this? <PQR alert> Custom table is empty! (look at the image attached)



Uploaded with ImageShack.us

bump still having problems!